Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Vite and Storybook #7229

Merged
merged 6 commits into from
Feb 21, 2024
Merged

Upgrade Vite and Storybook #7229

merged 6 commits into from
Feb 21, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Feb 19, 2024

Proposed Changes

  • upgrade vite to v5
  • upgrade storybook to latest verison

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@sainak sainak requested a review from a team as a code owner February 19, 2024 04:56
@vercel Vercel
Copy link

vercel bot commented Feb 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2024 1:34pm

@netlify Netlify
Copy link

netlify bot commented Feb 19, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit be1b10a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65d5fbca4430e20008219e1f
😎 Deploy Preview https://deploy-preview-7229--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress Cypress
Copy link

cypress bot commented Feb 19, 2024 •
edited
Loading

Passing run #2126 ↗︎

0 103 0 0 Flakiness 0

Details:

Upgrade Vite and Storybook
Project: CARE Commit: 9fae835398
Status: Passed Duration: 02:33 💡
Started: Feb 21, 2024 1:09 PM Ended: Feb 21, 2024 1:11 PM

Review all test suite changes for PR #7229 ↗︎

@sainak sainak force-pushed the sainak/feat/vite-5 branch from 2c38d63 to 652f5d3 Compare February 19, 2024 05:29
@github-actions github-actions bot added merge conflict pull requests with merge conflict labels Feb 21, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @sainak,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

1 similar comment
@github-actions GitHub Actions
Copy link

👋 Hi, @sainak,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@sainak sainak force-pushed the sainak/feat/vite-5 branch from 4b598c9 to 9fae835 Compare February 21, 2024 13:05
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Feb 21, 2024
@nihal467 nihal467 added the reviewed reviewed by a core member label Feb 21, 2024
khavinshankar
khavinshankar approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@khavinshankar khavinshankar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sainak LGTM, just 1 addition

can you please disable the eslint tailwind recommendation for h-5 w-5 -> size-5

@khavinshankar khavinshankar merged commit 86e461e into develop Feb 21, 2024
63 checks passed
@khavinshankar khavinshankar deleted the sainak/feat/vite-5 branch February 21, 2024 13:40
@github-actions GitHub Actions
Copy link

@sainak We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@Ashesh3 Ashesh3 Ashesh3 approved these changes

Assignees
No one assigned
Labels
reviewed reviewed by a core member tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sainak @Ashesh3 @rithviknishad @khavinshankar @nihal467